feat: automatic validator version fetching#91
Open
baarthur wants to merge 9 commits into
Open
Conversation
…function in NAMESPACE
Collaborator
|
this looks like a good suggestion that makes package maintenance much easier. The checks are failling for a few OSs , though. |
Author
|
the problem seems to be with java. it seems that I need to update the actions workflow to include the latest java and distro. be back in a few |
Author
|
Done. For the record, the main issue is that the new canonical validator requires java 17, whereas our checks were using java 11. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys,
I am proposing a few changes to how
download_validator()works. Instead of relying on a hardcoded vector of versions, this version fetches the latest version automatically. The main difference is in the helper functionget_validator_url(). As a downside, this addshttr2to the list of dependencies, which I believe is a minor nuisance sincehttr2is widely adopted and the gains in automation are high, by eliminating the need to manually update the list of versions.I also provided an optional
list_validator_versions(), which returns a df with the available CLI versions and their URLs. But honestly, I believe it is overkill, i.e., a user who wishes to use a later version probably knows it beforehand; otherwise, they may not have a strong reason to use, say, v5.0.0 instead of v7.0.0. It could also be used instead ofget_validator_url(), but I think the former works just fine, aslist_validator_versions()uses an API which is limited to 60 requests before authentication.Closes #86.