-
Notifications
You must be signed in to change notification settings - Fork 528
fix(files): not found page #2455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
Signed-off-by: Chayan Das <01chayandas@gmail.com>
d1e8f5c to
a717c5a
Compare
|
Triage note:
|
resolve conflict in FilesPage.js by keeping early not-found check and adding error prop
verify that browsing to a non-existing path shows the "Unable to load this path" error page with a working "Go to Files" button also fix flakiness by waiting for buttons to be enabled before clicking, and fix selector in invalid IPNS test
lidel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, rebased, all good.
Bug
FileNotFoundwas not displayed because of an early path check:When files.type === 'not-found', the paths differ, causing an early return.
##Fix
Render FileNotFound before checking for stale paths. This ensures missing files show the correct component.