Skip to content

Conversation

@ChayanDass
Copy link
Contributor

@ChayanDass ChayanDass commented Oct 23, 2025

Bug

FileNotFound was not displayed because of an early path check:

if (files.path && filesPathInfo.path && files.path !== filesPathInfo.path) {
  return null
}

When files.type === 'not-found', the paths differ, causing an early return.

##Fix

Render FileNotFound before checking for stale paths. This ensures missing files show the correct component.

image

@ChayanDass ChayanDass requested a review from a team as a code owner October 23, 2025 16:00
@welcome
Copy link

welcome bot commented Oct 23, 2025

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

Signed-off-by: Chayan Das <01chayandas@gmail.com>
@lidel
Copy link
Member

lidel commented Jan 24, 2026

Triage note:

lidel added 2 commits January 26, 2026 20:32
resolve conflict in FilesPage.js by keeping early not-found check
and adding error prop
verify that browsing to a non-existing path shows the
"Unable to load this path" error page with a working
"Go to Files" button

also fix flakiness by waiting for buttons to be enabled
before clicking, and fix selector in invalid IPNS test
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, rebased, all good.

@lidel lidel changed the title fix the file not found page fix(files): not found page Jan 26, 2026
@lidel lidel merged commit 18b9b0d into ipfs:main Jan 26, 2026
11 checks passed
@ChayanDass ChayanDass deleted the fix/file-not-found branch January 26, 2026 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing error when user tries to open missing file

2 participants