Skip to content

Conversation

@silvanocerza
Copy link
Contributor

Same as other libraries I duplicated some code to add support for the Lite API.

I had to fix some existing tests first as they were failing.

@silvanocerza silvanocerza requested a review from max-ipinfo June 27, 2025 08:04
@linear
Copy link

linear bot commented Jun 27, 2025

@silvanocerza
Copy link
Contributor Author

I think we need to update the token secret, I don't have permissions to do that.

@max-ipinfo
Copy link
Contributor

max-ipinfo commented Jun 27, 2025

I think we need to update the token secret, I don't have permissions to do that.

Done. It should work now.

Re-running checks.

@max-ipinfo
Copy link
Contributor

API tests are still not passing (https://github.com/ipinfo/ruby/actions/runs/15921375992/attempts/2):

IPinfoTest
  test_lookup_ip6                                                 FAIL (0.15s)
        Expected: "Hiroshima"
          Actual: "Osaka"
        /home/runner/work/ruby/ruby/test/ipinfo_test.rb:[12](https://github.com/ipinfo/ruby/actions/runs/15921375992/job/44943284550#step:6:13):in `assert_ip6'
        /home/runner/work/ruby/ruby/test/ipinfo_test.rb:160:in `block in test_lookup_ip6'
        /home/runner/work/ruby/ruby/test/ipinfo_test.rb:[15](https://github.com/ipinfo/ruby/actions/runs/15921375992/job/44943284550#step:6:16)8:in `each'
        /home/runner/work/ruby/ruby/test/ipinfo_test.rb:158:in `test_lookup_ip6'

@silvanocerza
Copy link
Contributor Author

@max-ipinfo tests are green 👍

@max-ipinfo max-ipinfo merged commit fd75d8a into master Jul 10, 2025
5 checks passed
@max-ipinfo max-ipinfo deleted the silvano/eng-290-add-lite-api-support-to-ipinforuby branch July 10, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants