Add support for actions - Do not merge!#51
Open
mauropasse wants to merge 220 commits intoirobot-ros:irobot/add-events-executorfrom
Open
Add support for actions - Do not merge!#51mauropasse wants to merge 220 commits intoirobot-ros:irobot/add-events-executorfrom
mauropasse wants to merge 220 commits intoirobot-ros:irobot/add-events-executorfrom
Conversation
added 30 commits
October 2, 2020 13:48
…id-ptr Check validity of executor pointer
use void * to pass executor ptr
…-executor Proper spin_some behaviour on EventsExecutor
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
remove smart pointer definitions for virtual class
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Alberto Soragna <alberto.soragna@gmail.com>
Signed-off-by: Soragna, Alberto <alberto.soragna@gmail.com>
Signed-off-by: Soragna, Alberto <alberto.soragna@gmail.com>
Asoragna/cleanup
Rework executor callback data
irobot-ros
force-pushed
the
irobot/add-events-executor
branch
from
0d50b6c to
48416d3
Compare
added 2 commits
March 15, 2021 15:12
Signed-off-by: Mauro Passerino <mpasserino@irobot.com>
irobot-ros
force-pushed
the
irobot/add-events-executor
branch
from
48416d3 to
91668ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this PR for reference, since the actions support should live in a different branch than
irobot/add-events-executorGoes together with irobot-ros/rcl#17