[#474,#494] Make input placeholder consistent and rename expiry parameter (main)#495
Merged
Conversation
alanking
reviewed
Jun 5, 2026
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
I'm guessing that the reason there are no test updates is because we don't really use the expiry field? It's fine not to have a test for it (because we don't use it) but just wanted to check.
Contributor
Author
Correct. I don't know that anything in the iRODS ecosystem uses the expiry time. |
Contributor
Author
|
Added pounds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All non-OIDC tests pass.