[_708] new __slots__ members to prevent configuration miswrites #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trel
reviewed
Jan 29, 2026
Comment on lines
+37
to
+39
| else: | ||
| pass | ||
| #success += 1 |
Member
There was a problem hiding this comment.
should the else be pulled one indentation back to match the if?
Contributor
There was a problem hiding this comment.
I think the else is supposed to match the try/except. But... it's also empty, so it may not be necessary, in any case.
Collaborator
Author
There was a problem hiding this comment.
Right, the else matches the try/except. the else clause runs if no exceptions are thrown.
Other places an else might not be expected, but is actually valid, is after a for loop , in which case it runs if the loop completes normally (rather than break-ing out)
And yes, I'll be taking out the counter variables success and count, eventually.
d-w-moore
commented
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Writing to misspelled dotted name configurations is now flagged as an error.