Skip to content

Network Virtualization Endpoints (NVEs) #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nikatza wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Network Virtualization Endpoints (NVEs) #123

nikatza wants to merge 3 commits into from

Conversation

@nikatza
Copy link
Contributor

@nikatza nikatza commented Nov 19, 2025 •
edited
Loading

Implements NVE(more specifically VTEP) API core type, and an extension for Cisco NX.

@hardikdr hardikdr added the area/metal-automation Automation processes within the Metal project. label Nov 20, 2025
@hardikdr hardikdr added this to Roadmap Nov 20, 2025
@nikatza nikatza force-pushed the feat/vteps branch 8 times, most recently from 07c2478 to bf5de61 Compare November 20, 2025 10:33
@nikatza nikatza changed the title DRAFT feat: enable VTEPs Virtual Tunnel End-Points (VTEPs) Nov 20, 2025
@nikatza nikatza marked this pull request as ready for review November 20, 2025 10:52
@nikatza nikatza requested a review from a team as a code owner November 20, 2025 10:52
@nikatza nikatza force-pushed the feat/vteps branch 4 times, most recently from 2e07dbb to bc6d0ad Compare November 21, 2025 08:26
felix-kaestner
felix-kaestner reviewed Nov 27, 2025
View reviewed changes
@nikatza nikatza force-pushed the feat/vteps branch 5 times, most recently from f8a67b7 to 5a01c3d Compare December 2, 2025 12:59
@nikatza nikatza marked this pull request as draft December 2, 2025 13:52
@nikatza nikatza force-pushed the feat/vteps branch 4 times, most recently from 9fbf0a8 to 0ffe93f Compare December 2, 2025 16:36
@nikatza nikatza force-pushed the feat/vteps branch 3 times, most recently from 185dab7 to 4f5e408 Compare December 3, 2025 00:15
@nikatza nikatza marked this pull request as ready for review December 3, 2025 00:15
@nikatza nikatza marked this pull request as draft December 3, 2025 12:12
@nikatza nikatza changed the title Virtual Tunnel End-Points (VTEPs) Network Virtuaization Endpoints (NVEs) Dec 3, 2025
@nikatza nikatza changed the title Network Virtuaization Endpoints (NVEs) Network Virtualization Endpoints (NVEs) Dec 3, 2025
@nikatza nikatza force-pushed the feat/vteps branch 3 times, most recently from d915b61 to 28c7872 Compare December 3, 2025 15:57
@nikatza nikatza marked this pull request as ready for review December 4, 2025 08:05
@github-actions
Copy link

github-actions bot commented Dec 4, 2025

Merging this branch changes the coverage (1 decrease, 4 increase)

Impacted Packages Coverage Δ 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/api/core/v1alpha1 0.00% (ø)
github.com/ironcore-dev/network-operator/cmd 0.00% (ø)
github.com/ironcore-dev/network-operator/internal/controller/cisco/nx 66.28% (ø)
github.com/ironcore-dev/network-operator/internal/controller/core 70.33% (+0.69%) 👍
github.com/ironcore-dev/network-operator/internal/provider 48.00% (+28.00%) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos 12.53% (+0.09%) 👍
github.com/ironcore-dev/network-operator/internal/webhook/cisco/nx/v1alpha1 89.47% (+89.47%) 🌟
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1 88.30% (-1.10%) 👎
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/nveconfig_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/cisco/nx/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/groupversion_info.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/nve_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/ref_types.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/api/core/v1alpha1/zz_generated.deepcopy.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/cmd/main.go 0.00% (ø) 0 0 0
github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller.go 75.81% (+75.81%) 186 (+186) 141 (+141) 45 (+45) 🌟
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/grpc.go 13.33% (ø) 15 2 13
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/nve.go 66.67% (ø) 6 (+3) 4 (+2) 2 (+1)
github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/provider.go 0.09% (-0.00%) 1070 (+10) 1 1069 (+10) 👎
github.com/ironcore-dev/network-operator/internal/provider/provider.go 48.00% (+28.00%) 25 12 (+7) 13 (-7) 🌟
github.com/ironcore-dev/network-operator/internal/webhook/cisco/nx/v1alpha1/nveconfig_webhook.go 89.47% (+89.47%) 38 (+38) 34 (+34) 4 (+4) 🌟
github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/nve_webhook.go 85.71% (+85.71%) 28 (+28) 24 (+24) 4 (+4) 🌟

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/nve_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/cisco/nx/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/nve_controller_test.go
  • github.com/ironcore-dev/network-operator/internal/controller/core/suite_test.go
  • github.com/ironcore-dev/network-operator/internal/provider/cisco/nxos/nve_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/cisco/nx/v1alpha1/nveconfig_webhook_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/cisco/nx/v1alpha1/webhook_suite_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/nve_webhook_test.go
  • github.com/ironcore-dev/network-operator/internal/webhook/core/v1alpha1/webhook_suite_test.go

@nikatza
Bump go dependencies
e7ff266 
Remove dependency replacement introduced to address CVE-2025-22868.
@nikatza
feat: Network Virtualization Endpoints (NVEs)
88865f8 
* Adds support for NVEs. The core type `NVE` requires at least two
  loopback interfaces on the same device, and an optional field for
Multicastgroup.
* Includes a Cisco NXOS specfic settings in
  `cisco.nx.v1alpha1.NVEConfig`
* The `NVEConfig` also modifies system and fabric forwarding settings.
@nikatza
Fix govet lint error: shadowing declaration
ee9ef65
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felix-kaestner felix-kaestner Awaiting requested review from felix-kaestner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area/metal-automation Automation processes within the Metal project.

Projects

Roadmap
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nikatza @felix-kaestner @hardikdr