Bring coord sig fig feedback in line with numeric questions#761
Closed
Bring coord sig fig feedback in line with numeric questions#761
Conversation
We use null in this context to mean "ignore significant figures", but this was previously causing the required sig figs to default to NUMERIC_QUESTION_DEFAULT_SIGNIFICANT_FIGURES (2).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
+ Coverage 39.87% 39.96% +0.08%
==========================================
Files 547 547
Lines 23905 23931 +26
Branches 2872 2880 +8
==========================================
+ Hits 9533 9564 +31
+ Misses 13466 13463 -3
+ Partials 906 904 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Don't break early on finding an incorrect sig figs match, in case another choice is a correct sig figs match.
Don't show sig fig feedback for an incorrect value with the correct number of sig figs that matches a choice value to 2s.f.
Assume there will not be distinct choices that differ only by significant figures.
… hotfix/coord-sig-figs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If min./max. significant figures aren't set on a coordinate question, use 2 as the default, as is the case for numeric questions.
Coordinate questions already showed sig figs feedback in the "correct but too many sig figs" case. Add feedback for the "too few sig figs, irrespective of correctness" case if and only if we have exhausted all other relevant feedback options, as is the case for numeric questions.
Enable significant figures feedback for both subset cases (submission ⊂ correct choice, subset match choice ⊂ submission).