Conversation
…rd-student [VRT] Update baselines for feature/my-ada-dashboard-student
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2026 +/- ##
==========================================
- Coverage 43.12% 43.08% -0.05%
==========================================
Files 578 579 +1
Lines 24902 24917 +15
Branches 8258 8230 -28
==========================================
- Hits 10740 10735 -5
- Misses 14112 14125 +13
- Partials 50 57 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sjd210
left a comment
sjd210
left a comment
There was a problem hiding this comment.
Perhaps just a url change, but also a question about Tutor support
| title: "Teacher mentoring", | ||
| icon: {name: "icon-group", color: "secondary"}, | ||
| bodyText: "Participate in live sessions with an experienced Ada CS mentor to get advice on teaching core topics.", | ||
| clickUrl: "/mentoring", |
There was a problem hiding this comment.
Should this be /teacher_mentoring? This doesn't currently lead anywhere
|
|
||
| export const Overview = () => { | ||
| const user = useAppSelector(selectors.user.orNull); | ||
| return isTeacherOrAbove(user) ? <TeacherOverview /> : <StudentOverview />; |
There was a problem hiding this comment.
On MyAdaSidebar you've added support for tutors, however here the links exist assuming that a tutor would have a student sidebar. This creates some strange discongruency (e.g. clicking a link and staying in the My Ada section, but not being in one of the sidebar locations).
Tutors aren't really supported on Ada anyway, right? If there are plans to enable support (which I didn't think was the case - but you coding a case for it makes me doubt that?), this should probably be fixed so tutors also have a fitting overview. Otherwise, it's not a big deal.
There was a problem hiding this comment.
I needed this because the tests assume tutor accounts exist, and the header navigation (now sidebar navigation) for tutors is being tested on Ada despite them not really existing; there is no distinct tutor overview page, however, because tutors don't really exist on Ada. It's a mess. I don't want to go to the effort of building a tutor page for it never to be used, so perhaps we just change this to isTutorOrAbove for consistency's sake and just deal with tests being shown to tutors, even though they can't really access them.
There was a problem hiding this comment.
Regardless, I've realised that tests need to run with all (non-_TEST_FEATURE_FLAG) feature flags off, which this branch wasn't doing. I'll need to revert that, which includes the tutor changes.
When we remove the flag, I'll re-apply these changes and set the above fn to isTutorOrAbove.
3 participants
Adds an Overview page for students. Everything should still be behind
FeatureFlag.ENABLE_ADA_SIDEBARS.The next plan is to overhaul the notifications, so please ignore any issues / oddities with the notification counter and where it should/n't be for now.