Skip to content

Fix race condition on deleting clickedItem#483

Open
odinho wants to merge 1 commit into
isteven:masterfrom
odinho:patch-1
Open

Fix race condition on deleting clickedItem#483
odinho wants to merge 1 commit into
isteven:masterfrom
odinho:patch-1

Conversation

@odinho

@odinho odinho commented Oct 11, 2016

Copy link
Copy Markdown

If you have some code removing all items before the timeout is
able to run, you'll get a nasty TypeError if you don't null check
clickedItem.

If you have some code removing all items before the timeout is
able to run, you'll get a nasty TypeError if you don't null check
clickedItem.
@odinho

odinho commented Oct 11, 2016

Copy link
Copy Markdown
Author

I saw a lot of this error when trying to make our selenium tests be free of console errors. The exception message in Opera and Chromium-based browsers is:

TypeError: Cannot convert undefined or null to object

@isteven

isteven commented Oct 12, 2016

Copy link
Copy Markdown
Owner

@odinho ,

Thanks for the PR. Can you ensure that this breaks none of the existing functionalities? If all are OK, I'm going to merge it.

@odinho

odinho commented Jul 18, 2018

Copy link
Copy Markdown
Author

I never got to write full tests. But it did not break any of the internal tests for Hola when I worked there, and this patch was (and still is) used for all their web pages and control panels. So it has seen a lot of use.

It shouldn't break something, but then maybe it will.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants