Instruct helm to keep workload groups around on deletion#3592
Merged
istio-testing merged 2 commits intoistio:masterfrom Oct 31, 2025
Merged
Instruct helm to keep workload groups around on deletion#3592istio-testing merged 2 commits intoistio:masterfrom
istio-testing merged 2 commits intoistio:masterfrom
Conversation
|
😊 Welcome @liamawhite! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
2067627 to
1de7e05
Compare
1de7e05 to
f9310af
Compare
howardjohn
approved these changes
Oct 31, 2025
Member
|
Nice find 👍 |
keithmattix
approved these changes
Oct 31, 2025
Collaborator
|
In response to a cherrypick label: new pull request created: #3593 |
Collaborator
|
In response to a cherrypick label: #3592 failed to apply on top of branch "release-1.26": |
Collaborator
|
In response to a cherrypick label: new issue created for failed cherrypick: #3594 |
Collaborator
|
In response to a cherrypick label: new pull request created: #3595 |
liamawhite
added a commit
to liamawhite/api
that referenced
this pull request
Oct 31, 2025
* Instruct helm to keep workload groups around on deletion * Add release notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other CRD has this annotation set so add it to WorkloadGroup.
Noticed this as I was root causing why this CRD was missing from one of our clusters.