Skip to content

Fix memory leak of CredHandle in wintls.c #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
+8 −5
Draft

Fix memory leak of CredHandle in wintls.c #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f8ef7a
Initial plan
Copilot Feb 28, 2026
95b2fb6
Fix memory leak in wintls.c: free CredHandle after FreeCredentialsHandle
Copilot Feb 28, 2026
973734a
Remove codeql build artifacts and update .gitignore
Copilot Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,3 +78,5 @@ Release
CMakeFiles
CMakeCache.txt
cmake_install.cmake
_codeql_build_dir/
_codeql_detected_source_root
10 changes: 5 additions & 5 deletions hconfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#endif

#ifndef HAVE_STDATOMIC_H
#define HAVE_STDATOMIC_H 0
#define HAVE_STDATOMIC_H 1
#endif

#ifndef HAVE_SYS_TYPES_H
Expand Down Expand Up @@ -62,15 +62,15 @@
#endif

#ifndef HAVE_PTHREAD_SPIN_LOCK
#define HAVE_PTHREAD_SPIN_LOCK 0
#define HAVE_PTHREAD_SPIN_LOCK 1
#endif

#ifndef HAVE_PTHREAD_MUTEX_TIMEDLOCK
#define HAVE_PTHREAD_MUTEX_TIMEDLOCK 0
#define HAVE_PTHREAD_MUTEX_TIMEDLOCK 1
#endif

#ifndef HAVE_SEM_TIMEDWAIT
#define HAVE_SEM_TIMEDWAIT 0
#define HAVE_SEM_TIMEDWAIT 1
#endif

#ifndef HAVE_PIPE
Expand All @@ -96,7 +96,7 @@
/* #undef ENABLE_UDS */
/* #undef USE_MULTIMAP */

#define WITH_WEPOLL 1
/* #undef WITH_WEPOLL */
/* #undef WITH_KCP */

#endif // HV_CONFIG_H_
1 change: 1 addition & 0 deletions ssl/wintls.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ void hssl_ctx_free(hssl_ctx_t ssl_ctx)
if (sec_status != SEC_E_OK) {
printe("free_cred_handle FreeCredentialsHandle %d\n", sec_status);
}
free(ssl_ctx);
}

static void init_sec_buffer(SecBuffer* secure_buffer, unsigned long type, unsigned long len, void* buffer)
Expand Down