New development from our side#25
Open
tis-dm-webfactory wants to merge 152 commits intoj-guyon:1.1from
Open
Conversation
added 30 commits
November 15, 2015 15:27
…ng.yml; TODO: actions for requirements
…ng translations to json
…s to json (new translations are missing - i don't speak french at all)
… added translations, added helper for cronexpressions
…command to rights
…nds with rights doesnt't work right now.
sensiolab badge in readme
sensiolabs config
sensiolabs config
travis green, about to test in productive environment
minor update to get a username
added fallback for old ".../list" route
update date filter in tables
increased memory_limit
changed default ordering
try to speed up command list
Contributor
|
i like some of the concepts here, however i think this is too large of a PR. IMO it should be broken into parts like: translation refactoring, execution logging, etc. Logrotate config from one of my project vagrants (no code to support/test!!): I was thinking of forking the project to implement execution logging, so maybe i'll just cherry pick your commits and make a smaller PR. |
Contributor
chrisjohnson00
left a comment
There was a problem hiding this comment.
:( another one bites the dust.
What was this bundle replaced with in your architecture?
There's a spelling mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
we (actually it was me in my free time) further extended the command scheduler.
It now supports restrictions to users and hosts, logging of executions (and return codes) to the database, cleanup of stored logs, executions history, "human readable" monitoring, ...
I changed the translation management to json - for me it was much easier to keep track of new translations in a "small" json file instead of a much more "complex" xml. Speaking of translations - nobody here speaks french good enough to translate the new texts, so these are still english.
We've also included your changes from our last PR ;-)
here you find the results of my last build:
https://insight.sensiolabs.com/projects/f0991948-dd04-4f4d-a6a4-1a348d1ceb57
https://travis-ci.org/homerjsimpson000/CommandSchedulerBundle
https://coveralls.io/github/homerjsimpson000/CommandSchedulerBundle?branch=master
we still are stuck to php 5.3.something, so I implemeted everything that it works with 5.3 as well as 7...
I hope, you like the extensions we've added
greetings from Tyrol/Austria