This repository was archived by the owner on Apr 20, 2022. It is now read-only.
alsa_in/out: Convert between sample rates when necessary#8
Open
mildsunrise wants to merge 1 commit intojackaudio:masterfrom
Open
alsa_in/out: Convert between sample rates when necessary#8mildsunrise wants to merge 1 commit intojackaudio:masterfrom
mildsunrise wants to merge 1 commit intojackaudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
alsa_inandalsa_outset the playback latency of their ports to the target delay. The problem is the target delay is in terms of the ALSA sample rate, so it should be converted to JACK's sample rate.Example: Imagine JACK is running at 48 kHz, and
alsa_outis invoked like:Currently,
alsa_outwill report 512 frames of playback latency. After the fix, it converts to 48kHz and correctly reports 256.Also converts the result of
jack_frames_since_cycle_startto ALSA sample rate.