Conversation
This form can be submitted & validated entirely without JS on the client :)
|
|
||
| renderForm() { | ||
| return ( | ||
| <form method="post" action="/submit-email-form" onSubmit={this.formSubmit}> |
Owner
Author
There was a problem hiding this comment.
In a non-JS world the form will submit like a regular form would to /submit-email-form, but in a JS world React will capture it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot of people ask me how I would deal with forms in a Universal React world. When I say I'd just make it submit either on the server or in the client, they ask how to avoid writing it twice.
This PR shows a basic approach (there's plenty of room for improvement) where any logic around validating the form is in a universal module used on both the client and the server. You write:
POSTed to in a non-JS environmentNote that I won't merge this PR as I want to keep the basic repo as straightforward as it can be, but I hope this helps some people.
I'll blog more about this soon...