Open
Conversation
Collaborator
|
I agree that this operation is nice, but indeed I'd like to keep RFC 6902 compatibility, which means I'll need to refactor and make As to the patch itself, it looks good, but I'd suggest the following changes:
|
Author
|
Thanks! I'll make an update using your suggestions. |
Refactor AdditionOperation
Author
|
Squashed |
Author
|
Updated to make |
Collaborator
|
Excellent! Now I need to find the time to work on that project again... Right now I'm busy with json-schema-*... |
Author
|
Thanks, I'll keep an eye out for any updates. |
stephanedaviet
pushed a commit
to stephanedaviet/json-patch
that referenced
this pull request
Apr 6, 2019
…eration Add remove? operation
BartekGravity
pushed a commit
to gravity9-tech/json-patch-path
that referenced
this pull request
Jun 20, 2023
…son_pointer_double_slashes #807 JsonPointer double slashes validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd like to extend JSON Patch and add a new "create" operation. It is exactly like "add", except it will not replace an existing value at the requested path. It will be useful in situations in where a client wants to ensure that they are not overwriting a value set by another client.
This was a suggestion from an email thread with the RFC6902 authors:
Although it deviates from the RFC, I think it would be useful for others to use, perhaps in a custom JsonPatch implementation as you mentioned in #9.
Let me know what you think!