Informative msgs when JsonPatchException is thrown#103
Open
objectsmiths wants to merge 2 commits intojava-json-tools:masterfrom
Open
Informative msgs when JsonPatchException is thrown#103objectsmiths wants to merge 2 commits intojava-json-tools:masterfrom
objectsmiths wants to merge 2 commits intojava-json-tools:masterfrom
Conversation
objectsmiths
commented
Jul 7, 2021
- This PR adds informative msgs to the cases when JsonPatchException is thrown . (for example a missing path is passed etc.).
- All the tests have been modified to take in to account the new messages.
- We have used this software in our internal project and found it useful to have this information when some thing changed on our backend and the front end was in sync. It would throw generic jsonPatchException (with noSuchPath or noSuchParent which while useful would not pin point to the location of the error. This becomes a problem in projects with quite a few team members who are not proficient in debugging and the architecture is complex.
- All the tests are passing after the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.