bug fix in move operation

[vishwakarma]

There was bug in factorization of diffs while finding pairs.
Example :
"first": { "b": [0, 1, 2] },
"second": { "b": [1, 2], "c": 0 ,"d":0}
patch obtained is :
{{ "op": "move", "from": "/b/0", "path": "/c"}, { "op": "move", "from": "/b/0", "path": "/d"}}
which is wrong, the correct patch generated should be
{ "op": "move", "from": "/b/0", "path": "/c"},{ "op": "add", "path": "/d", "value": 0}
There was bug in finding pair method, I have added necessary code fix for same.

[fge]

Uh, sorry, I only just noticed this pull request...

Does it also solve the other issue you mentioned?

[vishwakarma]

Hi, the pull request doesn't solve all cases, it solve cases covered by shared example, The whole MOVE operation needs to revisit.

[vishwakarma]

Hi, I have written java implementation names as zjsonpatch https://github.com/flipkart-incubator/zjsonpatch, it covers all cases which are currently missing in json-patch project.
Currently, This is being used in my some other project where daily 70+Million jsons are compared (checked for diff and applied same if diff found), this is live from last 3 months with no issues reported, Variations in json used are ranging from 5-300 keys with multiple level of nesting (array within object or vice-versa) and latency perceived is 99.9 percentile 1ms .

[fge]

@vishwakarma which cases are missing? None are missing. JSON Patch works and so does JSON Merge Patch.

And so does JSON Diff! It just doesn't optimize everything. But it works reliably.