Fix implementation of fn every#8
Closed
lrusso96 wants to merge 1 commit intojesseduffield:masterfrom
lrusso96:fix-every
Closed
Fix implementation of fn every#8lrusso96 wants to merge 1 commit intojesseduffield:masterfrom lrusso96:fix-every
lrusso96 wants to merge 1 commit intojesseduffield:masterfrom
lrusso96:fix-every
Conversation
| let passed = true; | ||
| map(arr, fn(e) { | ||
| switch check(e) { case true: passed = false; } } | ||
| switch check(e) { case false: passed = false; } } |
| }; | ||
|
|
||
| result = every([5,2,4,1,3], fn(e) { return e >= 2 }); // false | ||
| result1 = every([5,2,4,1,3], fn(e) { return e >= 2 }); // false |
Owner
There was a problem hiding this comment.
To keep things simple I would just leave this bit as it was
jesseduffield
requested changes
Nov 12, 2022
Owner
jesseduffield
left a comment
There was a problem hiding this comment.
Thanks for making this. Just one thing
Author
|
I close this as explained in #19. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there is a typo in this example: the switch clause is wrong.
Check the code on an array of integers all greater than 2 and the result would be false as well.
OK/README.md
Lines 381 to 391 in d150075