Skip to content

Fix: lazygit crash on startup because of terminal name update#5415

Open
jpthompson212 wants to merge 2 commits intojesseduffield:masterfrom
jpthompson212:fix/5414-lazygit-crash-on-startup
Open

Fix: lazygit crash on startup because of terminal name update#5415
jpthompson212 wants to merge 2 commits intojesseduffield:masterfrom
jpthompson212:fix/5414-lazygit-crash-on-startup

Conversation

@jpthompson212
Copy link
Copy Markdown

PR Description

Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • If a new UserConfig entry was added, make sure it can be hot-reloaded (see here)
  • Docs have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@stefanhaller
Copy link
Copy Markdown
Collaborator

Looks reasonable, but I'd be curious what the error was, and whether we are looking at some other root cause that might be fixed earlier on.

@jpthompson212
Copy link
Copy Markdown
Author

I can try and debug it some more and figure out what might be the root cause, but in general failing to rename the terminal should not cause a crash the application.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants