fix: resolve symlink before initializing repo paths#5454
Closed
renezander030 wants to merge 1 commit intojesseduffield:masterfrom
Closed
fix: resolve symlink before initializing repo paths#5454renezander030 wants to merge 1 commit intojesseduffield:masterfrom
renezander030 wants to merge 1 commit intojesseduffield:masterfrom
Conversation
When the current working directory is a symlink to a directory inside a git repo, os.Getwd() returns the symlink path which causes lazygit to fail to find the git repository. Resolve symlinks via filepath.EvalSymlinks before passing the path to GetRepoPathsForDir. Fixes jesseduffield#3015
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
TIP This summary will be updated as you push new changes. Give us feedback
Collaborator
|
We had the same PR a few days ago (#5417), and my question on that PR (which wasn't answered) applies here, as well. |
Author
|
You're right - PR #3183 switched to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetRepoPaths(viafilepath.EvalSymlinks) before passing it toGetRepoPathsForDiros.Getwd()returns the symlink path, causing lazygit to fail to locate the.gitdirectoryworktree/symlink_into_repo_subdircovers this scenarioTest plan
go build ./...compiles successfullygo test ./pkg/commands/git_commands/...passesFixes #3015