Conversation
Add `agentcore tag` command for managing AWS resource tags on agents, memories, and gateways. Supports project-level default tags (inherited by all resources) and per-resource tag overrides. - Add TagsSchema to project, agent, memory, and gateway schemas - Add `tag list|add|remove|set-defaults|remove-defaults` subcommands - Auto-tag new projects with `agentcore:created-by` and `agentcore:project-name` - Add unit tests for schema validation and tag actions - Add integration tests for tag command round-trip
tejaskash
force-pushed
the
feat/resource-tagging
branch
from
10a7dcb to
a5fe86a
Compare
Package Tarballaws-agentcore-0.3.0-preview.6.0.tgz How to installnpm install https://github.com/jesseturner21/agentcore-cli/releases/download/pr-5-tarball/aws-agentcore-0.3.0-preview.6.0.tgz |
Coverage Report
|
| return { | ||
| name: projectName, | ||
| version: 1, | ||
| tags: { |
There was a problem hiding this comment.
I see this duplicated in a few places, does it make sense to centralize it to avoid drift?
| @@ -0,0 +1,6 @@ | |||
| import type { TaggableResourceType } from './types'; | |||
|
|
|||
| export const TAGGABLE_RESOURCE_TYPES: readonly TaggableResourceType[] = ['agent', 'memory', 'gateway']; | |||
There was a problem hiding this comment.
is this duplicated in src/cli/commands/tag/types.ts?
|
|
||
| export const TAGGABLE_RESOURCE_TYPES: readonly TaggableResourceType[] = ['agent', 'memory', 'gateway']; | ||
|
|
||
| export const NON_TAGGABLE_NOTE = |
There was a problem hiding this comment.
I don't see this used, is there a future plan for it?
| return { projectDefaults, resources }; | ||
| } | ||
|
|
||
| export async function addTag(resourceRefStr: string, key: string, value: string): Promise<{ success: boolean }> { |
There was a problem hiding this comment.
should we apply the schema from src/schema/schemas/primitives/tags.ts here?
| @@ -0,0 +1,6 @@ | |||
| import { z } from 'zod'; | |||
|
|
|||
| export const TagKeySchema = z.string().min(1).max(128); | |||
There was a problem hiding this comment.
are there any reserved tags or limits? Ex. ECS doesn't allow more than 50 or aws prefix. Do we know if there are similar rules for AgentCore?
|
|
||
| ### tag | ||
|
|
||
| Manage AWS resource tags on your AgentCore project. Tags are applied to deployed CloudFormation resources (agents, |
There was a problem hiding this comment.
Where exactly do we propagate the tags to cloudformation? Is there a dependent CR to cdk we need to merge or is that already supported automatically?
2 participants
Summary