Add Helm support for Grafana dashboard annotations (including folder assignment)#432
Open
Copilot wants to merge 3 commits into
Open
Add Helm support for Grafana dashboard annotations (including folder assignment)#432Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/jetstack/version-checker/sessions/24490605-78f6-4eda-84d3-1b87a2da37cb Co-authored-by: davidcollom <1504448+davidcollom@users.noreply.github.com>
Agent-Logs-Url: https://github.com/jetstack/version-checker/sessions/24490605-78f6-4eda-84d3-1b87a2da37cb Co-authored-by: davidcollom <1504448+davidcollom@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for annotations on Grafana dashboard
Add Helm support for Grafana dashboard annotations (including folder assignment)
May 9, 2026
davidcollom
approved these changes
May 9, 2026
There was a problem hiding this comment.
Pull request overview
Adds first-class Helm values and template support to attach arbitrary metadata.annotations onto the chart-managed Grafana dashboard resources, enabling workflows like Grafana Operator folder assignment via grafana_folder.
Changes:
- Added
dashboards.annotationsto chart values (and documented it) to allow user-supplied annotations. - Rendered
dashboards.annotationsonto the dashboardsConfigMapand bothGrafanaDashboardCRs (when the CRD is available), alongside a small label indentation normalization. - Extended Helm unit tests to assert annotation rendering on both ConfigMap and GrafanaDashboard manifests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/charts/version-checker/values.yaml | Exposes dashboards.annotations in the chart values API. |
| deploy/charts/version-checker/templates/dashboards.yaml | Renders metadata.annotations for dashboard resources (ConfigMap + GrafanaDashboard CRs). |
| deploy/charts/version-checker/tests/dashboards_test.yaml | Adds unit assertions that annotations are rendered correctly. |
| deploy/charts/version-checker/README.md | Documents the new dashboards.annotations value in the values table. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
davidcollom
approved these changes
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users enabling chart-managed Grafana dashboards could not attach annotations to the generated dashboard resources, which blocked common workflows like folder assignment via
grafana_folder. This change adds first-class annotations support for dashboard manifests.Helm values surface
dashboards.annotationsto chart values to allow arbitrary metadata annotations on dashboard resources.Dashboard template rendering
templates/dashboards.yamlto rendermetadata.annotationsfromdashboards.annotationson:ConfigMapGrafanaDashboardresources (generalandinternal) when CRDs are available.GrafanaDashboardblocks while touching this area.Chart tests and docs
tests/dashboards_test.yamlto assert annotation rendering on both ConfigMap and GrafanaDashboard manifests.dashboards.annotations.Example values: