AX-1579 - Make MCP secret-persistence guidance shell-aware#8
Open
YoniMelki wants to merge 1 commit into
Open
Conversation
Persisting MCP secrets previously told users to add the export to ~/.zshrc, which only works for zsh users. Replace that with shell-keyed guidance (zsh/bash/fish, plus Windows setx) and tell the agent to detect the shell, so the export lands in the file the user's shell actually sources. Bump plugin version 0.2.1 -> 0.2.2. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
YoniMelki
force-pushed
the
bugfix/AX-1579-envar-instructions
branch
from
21b2348 to
3ef8314
Compare
yanivt-jfrog
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the hardcoded
~/.zshrcpersistence instruction in the MCP management template with shell-aware guidance.Why
The agent told users to persist MCP secret env vars by adding the
exportto~/.zshrc, which only works for zsh. Users on bash/fish/Linux/Windows added it to a file their shell never sources, so the variable was silently lost on next launch and the IDE "ignored" the config.Changes
templates/jfrog-mcp-management.md: secret-persistence guidance now keys on the user's shell, not the OS — zsh →~/.zshrc, bash →~/.bashrc(and macOS~/.bash_profile), fish →~/.config/fish/config.fish, Windows →setx— and tells the agent to detect the shell first.0.2.1→0.2.2.🤖 Generated with Claude Code