fix: skip credentials for public releases.jfrog.io downloads#1340
Open
toller892 wants to merge 1 commit into
Open
fix: skip credentials for public releases.jfrog.io downloads#1340toller892 wants to merge 1 commit into
toller892 wants to merge 1 commit into
Conversation
download_to(), head_request(), and storage_request() unconditionally used JF_ACCESS_TOKEN / JF_USER credentials when set, even when downloading from the public releases.jfrog.io server. This caused 401 errors for users who have their own Artifactory credentials (JF_URL + JF_USER) configured but are not using JF_RELEASES_REPO. Guard all three functions with a REMOTE_PATH check — credentials are only sent when JF_RELEASES_REPO is configured, which means the URL points to the user's own Artifactory instance. Fixes jfrog#1339
Contributor
|
I have read the CLA Document and I hereby sign the CLA toller892 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
download_to(),head_request(), andstorage_request()unconditionally useJF_ACCESS_TOKEN/JF_USERcredentials when set — even when downloading from the publicreleases.jfrog.ioserver.This breaks the use case where a user has their own Artifactory credentials configured (
JF_URL+JF_USER+JF_PASSWORD) but is not usingJF_RELEASES_REPO. The script sends those credentials toreleases.jfrog.io, which returns 401 because the user doesn't exist there.Fixes #1339
Fix
Guard all three HTTP helper functions with a
REMOTE_PATHcheck. Credentials are only sent whenJF_RELEASES_REPOis configured (which setsREMOTE_PATH), meaning the URL points to the user's own Artifactory instance. When downloading from the public server, no credentials are sent.Before
After
Affected functions
download_to()— binary downloadhead_request()— HEAD for checksum headersstorage_request()— Artifactory Storage API fallbackBehavior matrix
REMOTE_PATHJF_RELEASES_REPO)JF_RELEASES_REPOset)