Improving logs for V2#1341
Open
eranturgeman wants to merge 2 commits into
Open
Conversation
Collaborator
eranturgeman
commented
Jun 2, 2026
eranturgeman
commented
- All tests passed. If this feature is not already covered by the tests, I added new tests.
- This pull request is on the dev branch.
- I used gofmt for formatting the code before submitting the pull request.
- Update documentation about new features / new supported technologies
eranturgeman
added
safe to test
github-actions
Bot
removed
the
safe to test
eranturgeman
added
the
safe to test
github-actions
Bot
removed
the
safe to test
attiasas
approved these changes
Jun 2, 2026
Contributor
attiasas
left a comment
attiasas
left a comment
There was a problem hiding this comment.
LGTM, make sure there are no more tokens left to be printed that are no masked
|
|
||
| configAggregatorParamsString, e := json.Marshal(params) | ||
| if e == nil { | ||
| log.Debug(fmt.Sprintf("extracted config aggregator params: %s", configAggregatorParamsString)) |
Contributor
There was a problem hiding this comment.
Suggested change
| log.Debug(fmt.Sprintf("extracted config aggregator params: %s", configAggregatorParamsString)) | |
| log.Verbose(fmt.Sprintf("extracted config aggregator params: %s", configAggregatorParamsString)) |
maybe verbose level?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.