Fix bug regarding cyclonedx format with contextFlags and --vuln flag #687
Open
eranturgeman wants to merge 2 commits intojfrog:devfrom
Open
Fix bug regarding cyclonedx format with contextFlags and --vuln flag #687eranturgeman wants to merge 2 commits intojfrog:devfrom
eranturgeman wants to merge 2 commits intojfrog:devfrom
Conversation
attiasas
approved these changes
Feb 26, 2026
Collaborator
attiasas
left a comment
There was a problem hiding this comment.
LGTM, check out my comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

devbranch.go vet ./....go fmt ./....This PR fixes the following issue:
Cyclonedx output does not support currently in violations. When providing a context flag (--project/ --repoPath/ --watches) we always assume violations context.
When we add --vuln flag we expect for vulnerabilities as well, and those can be parsed into the CDX. Also - not every time we use a project we actually want to be in violations mode.
I added an overpass for the scenario when a cycloneDx is requested with a context flag and --vuln. In this scenario only vulnerabilities will be parsed, excluding violations.
I added an indicative log explaining that as well as an addition to the --format flag.