Added native huggingface native commands and e2e and workflow tests#3341
Merged
naveenku-jfrog merged 7 commits intojfrog:masterfrom Feb 17, 2026
Conversation
naveenku-jfrog
added
the
safe to test
naveenku-jfrog
added
safe to test
…on-command-in-jf-cli_
naveenku-jfrog
added
safe to test
agrasth
changed the title
agrasth
reviewed
Feb 12, 2026
Comment on lines
+1196
to
+1199
| repoType := c.String("repo-type") | ||
| if repoType == "" { | ||
| repoType = "model" | ||
| } |
Contributor
There was a problem hiding this comment.
Default values for repoType are set in the command functions, but the flag definition says "[Default: model]" which suggests it should be set at the flag level.
Default should be in the flag definition, not in the command logic. This is inconsistent with how other flags work.
Comment on lines
+198
to
+202
| err = jfrogCli.Exec(args...) | ||
| if err != nil { | ||
| // Expected to fail without proper HuggingFace credentials | ||
| t.Logf("HuggingFace upload command returned: %v (this is expected without HF credentials)", err) | ||
| } |
Contributor
There was a problem hiding this comment.
These are not actually validating the HuggingFace functionality works. Is this expected in next set of PR?
If yes, for such cases we can directly add e2es when functionality is fully done, this can avoid rework. WDYT?
Collaborator
Author
There was a problem hiding this comment.
Fully functionalities will be part of next PR.
naveenku-jfrog
added
safe to test
agrasth
approved these changes
Feb 13, 2026
naveenku-jfrog
added
safe to test
…on-command-in-jf-cli_
naveenku-jfrog
added
safe to test
…on-command-in-jf-cli_
naveenku-jfrog
added
safe to test
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....What: Added native hhuggingface native commands and e2e and workflow tests
Depend on other PR: Yes, jfrog/jfrog-cli-artifactory#359