Improve 19 error messages: fix typos, add actionable guidance, clarify wording#3345
Open
Balasubramanyamkosuri wants to merge 2 commits intojfrog:masterfrom
Open
Improve 19 error messages: fix typos, add actionable guidance, clarify wording#3345Balasubramanyamkosuri wants to merge 2 commits intojfrog:masterfrom
Balasubramanyamkosuri wants to merge 2 commits intojfrog:masterfrom
Conversation
…fy wording Tier 1 - Typos and grammar: - Fix "exit" -> "exist" typo in config/cli.go - Fix "Skiping" -> "Skipping" typo in signatureutils.go - Remove redundant "latest" in GitHub API error message - Fix "ID's" -> "IDs" and improve reserved server ID error Tier 2 - Wording improvements: - Clarify GitHub rate limit error with env var name (JFROG_CLI_GITHUB_TOKEN) - Add suppression hint for invalid version tag error - Reword confusing double-negative in fail-no-op message - Replace deprecated "API key" with "access token" - Update old binary name "jfrog" to "jf" in config hint Tier 3 - Actionable guidance: - Add example to --deb option error (e.g., bionic/main/amd64) - List supported Terraform commands in error - List valid sections in summary error - Add --url flag hint to lifecycle platform URL error - Add remediation steps to Pipelines URL error - Add CSV format hint to users create error - Add usage example to users delete error - Add build command guidance to "no modules" error - Add Poetry source configuration hint Co-authored-by: Cursor <cursoragent@cursor.com>
Go convention (enforced by staticcheck) requires error strings to not end with punctuation. Removed trailing periods from three error messages. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files Changed (8 files, 19 lines changed)
config/cli.goplugins/utils/signatureutils.goutils/cliutils/utils.gobuildtools/cli.gogeneral/summary/cli.goartifactory/cli.gopipelines/cli.goutils/buildinfo/buildinfo.goTest Plan
go build ./...Made with Cursor