Feature/rteco 814 implement build info collection for hugging face#3352
Open
naveenku-jfrog wants to merge 5 commits intojfrog:masterfrom
Open
Conversation
naveenku-jfrog
added
the
safe to test
Contributor
fluxxBot
requested changes
Feb 16, 2026
| case "d", "download": | ||
| return huggingFaceDownloadCmd(c, hfArgs, serverDetails, buildConfiguration) | ||
| default: | ||
| return errors.New("Wrong command: " + cmdName) |
Contributor
There was a problem hiding this comment.
As much as I understood, artifactory does not support commands other than upload or download, then for default case:
- either we should let it be passthrough and let artifactory through error. In this way we will not miss out much incase server any fine day releases other commands support for hugging face.
- or, we should improve error message.
Comment on lines
+1160
to
+1170
| if len(hfArgs) < 2 { | ||
| return cliutils.PrintHelpAndReturnError("Folder path and repository ID are required.", c) | ||
| } | ||
| folderPath := hfArgs[0] | ||
| if folderPath == "" { | ||
| return cliutils.PrintHelpAndReturnError("Folder path cannot be empty.", c) | ||
| } | ||
| repoID := hfArgs[1] | ||
| if repoID == "" { | ||
| return cliutils.PrintHelpAndReturnError("Repository ID cannot be empty.", c) | ||
| } |
Contributor
There was a problem hiding this comment.
I guess last two cases are redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....What: Added build info collection logic for hugging face download and upload command
Depend on other PR: Yes, jfrog/jfrog-cli-artifactory#368
Testing: Done, On artifactory instance