Fix coordinator control handoff#137
Open
brooksc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Coordinator control handoff could stall or diverge across UI/backend state. Releasing human control only notified the coordinator after a blocked send_prompt, not after wait_for_idle was interrupted. The renderer also persisted optimistic control state before backend acknowledgement, so frontend and backend ownership could drift.
Fix
Track idle waits interrupted by human control and stage the same resume notification when control returns to the coordinator. Make backend control changes fail loudly for missing coordinator state or unknown tasks. Persist renderer control state only after backend acknowledgement, with rollback on failure, and make auto-trust release wait for backend acknowledgement before updating UI state.
Verification
git diff --checknpm run checknpm testjohannesjo/mainelectron/ipc/register.tselectron/mcp/coordinator.test.tselectron/mcp/coordinator.tssrc/store/taskStatus.tssrc/store/tasks.test.tssrc/store/tasks.ts