Fix terminal PTY interruptions during remounts#138
Open
brooksc wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Task AI terminals currently terminate their backend PTY when the TerminalView component cleans up. In dev/HMR or other renderer remounts, that kills an active Codex session, then the renderer respawns it with resume args. Codex sees that as an interrupted conversation and waits for manual continuation.
Fix
Task AI terminals now preserve their PTY across component cleanup and reattach to the existing process on remount. Intentional replacement remains explicit: restart and agent switch set attachExisting=false, so those actions still replace the running process. Standalone close/cleanup paths continue to own termination.
Verification