Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 42 additions & 0 deletions src/store/persistence.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,48 @@ describe('coordinator control hint persistence', () => {
});
});

describe('coordinator control defaults', () => {
it('restores coordinator tasks to human control when persisted state omits controlledBy', async () => {
mockInvoke.mockResolvedValueOnce(
basePayload({
taskOrder: ['coord-1'],
tasks: {
'coord-1': {
...persistedTask(agentDef()),
id: 'coord-1',
coordinatorMode: true,
},
},
activeTaskId: 'coord-1',
}),
);

await loadState();

expect(store.tasks['coord-1']?.controlledBy).toBe('human');
});

it('restores coordinated child tasks to coordinator control when persisted state omits controlledBy', async () => {
mockInvoke.mockResolvedValueOnce(
basePayload({
taskOrder: ['child-1'],
tasks: {
'child-1': {
...persistedTask(agentDef()),
id: 'child-1',
coordinatedBy: 'coord-1',
},
},
activeTaskId: 'child-1',
}),
);

await loadState();

expect(store.tasks['child-1']?.controlledBy).toBe('coordinator');
});
});

describe('projects section collapsed persistence', () => {
it('defaults to expanded when not in saved state', async () => {
setStore('projectsCollapsed', true);
Expand Down
6 changes: 4 additions & 2 deletions src/store/persistence.ts
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,8 @@ export async function loadState(): Promise<void> {
propagateSkipPermissions: pt.propagateSkipPermissions,
coordinatedBy: pt.coordinatedBy,
controlledBy:
pt.controlledBy ?? (pt.coordinatorMode || pt.coordinatedBy ? 'coordinator' : undefined),
pt.controlledBy ??
(pt.coordinatedBy ? 'coordinator' : pt.coordinatorMode ? 'human' : undefined),
// Defer TerminalView spawn until StartMCPServer/hydrateTask complete —
// the config file has a stale token from the previous session until then.
mcpStartupStatus:
Expand Down Expand Up @@ -777,7 +778,8 @@ export async function loadState(): Promise<void> {
propagateSkipPermissions: pt.propagateSkipPermissions,
coordinatedBy: pt.coordinatedBy,
controlledBy:
pt.controlledBy ?? (pt.coordinatorMode || pt.coordinatedBy ? 'coordinator' : undefined),
pt.controlledBy ??
(pt.coordinatedBy ? 'coordinator' : pt.coordinatorMode ? 'human' : undefined),
mcpStartupStatus:
pt.coordinatorMode || pt.coordinatedBy ? ('pending' as const) : undefined,
mcpConfigPath: pt.mcpConfigPath,
Expand Down
2 changes: 1 addition & 1 deletion src/store/tasks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ export async function createTask(opts: CreateTaskOptions): Promise<string> {
propagateSkipPermissions: opts.coordinatorMode
? (opts.propagateSkipPermissions ?? false)
: undefined,
controlledBy: opts.coordinatorMode ? 'coordinator' : undefined,
controlledBy: opts.coordinatorMode ? 'human' : undefined,
mcpConfigPath,
mcpLaunchArgs,
// Coordinator tasks call StartMCPServer before entering the store, so MCP is ready immediately.
Expand Down
Loading