Open
Conversation
(test_assign_fields.py/EscapeTest is known to fail. Where the escape of a field is done needs to be resolved.)
escaped field value.
…the un-parsable escape to the output. An optional parameter allows calling for errors to be logged.
Don't log the field value. In the case of reports, the field maybe very long
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made changes to accomplish two things.
First, Segment.assign_field() correctly re-writes values. The caller can redefine the structure of the hl7 message.
Second, a new function in Message and Segment, write_field(), first escapes the field and then calls assign_field(). This was my solution to provide write-with-escape in a backward compatible way.