Updated jQuery implementation to use some real common-place best practices#2
Open
mattjcowan wants to merge 1 commit intojonmiles:masterfrom
Open
Updated jQuery implementation to use some real common-place best practices#2mattjcowan wants to merge 1 commit intojonmiles:masterfrom
mattjcowan wants to merge 1 commit intojonmiles:masterfrom
Conversation
…actice) optimizations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not pretending to be a jQuery expert or React expert, but seems like the jQuery implementation really needed some basic updates to make it a fair comparison, nothing complex at all. I grabbed a few best-practices from the jQuery docs, and put in a few things that seemed to me like basic conventions when using a dom library like jQuery. Let me know what you think.