Added Web Images Support =) #18
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
August 29, 2014 18:40
… and other pods if necessary
…pace file instead of the .xcodeproj file -added Needed pods -updated the podsSpec file for dependencies on used pods
-coded the setting of JPSThumbnailAnnotaionView's imageView property by checking if the image property is set: if it is, then it is used directly. otherwise, the imageURL is used instead. -updated Demo project to use an example of a Web fetched image
This reverts commit 4dcb3b2.
… 1.2.1" This reverts commit b19e641.
Contributor
|
Hi, Just in case you want to check I added a pull request today with a more simple approach adding only SDWebImage, here is the link #28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Web image support using SDWebImage (more accurately, 'UIActivityIndicator-for-SDWebImage') Pod: now the JPSThumbnail has a new property named: imageURL where the URL for the thumbnail can be set, instead of the image property (this latter one must be left as nil in order to use the imageURL property).
-Changed demo project to Use Cocoapods, in order to be able to Use the UIActivityIndicator-for-SDWebImage Pod
-Added the UIActivityIndicator-for-SDWebImage dependency into the podspec file.
-Updated README file to reflect the new feature.