rename JSONRPCError field msg -> message

[ZacLN]

msg was inconsistent with the JSONRPC spec and usage within the package (catch block of dispatch_msg).

Not clear if this requires downstream changes/version bump?

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 3.70%. Comparing base (b2b474b) to head (70d6aff).
⚠️ Report is 170 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core.jl	0.00%	1 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff          @@
##            main     #18   +/-   ##
=====================================
  Coverage   3.70%   3.70%           
=====================================
  Files          4       4           
  Lines        135     135           
=====================================
  Hits           5       5           
  Misses       130     130           

Flag	Coverage Δ
unittests	3.70% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidanthoff]

On the other hand, the Julia exception types all use msg, that is why I used that here as well. Is there actually an accessor function in Julia that generically extracts the message from an exception type and abstracts away of the precise field names?

[ZacLN]

I'm referring to https://github.com/julia-vscode/JSONRPC.jl/blob/master/src/typed.jl#L71 rather than the within-julia error throwing. The receiver of that error message will expect to get a "message" entry won't they?

[davidanthoff]

The code you link to is a bug, #16 is meant to fix that. We should probably merge that first before we make further changes.

[davidanthoff]

Do you think we should still do this, or is the current master version fine?

[ZacLN]

It's mildly confusing, may as well change it

[davidanthoff]

Cool, sounds good.

I think it also need to be changed at https://github.com/julia-vscode/JSONRPC.jl/blob/master/src/typed.jl#L67.

I don't think any of the downstream packages need an update.

[davidanthoff]

@ZacLN Bump, I think you need to make one more change and then we can merge this.