when using helpers, only add “sv-visibility-hidden” on move#48
Closed
ebemunk wants to merge 1 commit intokamilkp:masterfrom
ebemunk:helper-fix
Closed
when using helpers, only add “sv-visibility-hidden” on move#48ebemunk wants to merge 1 commit intokamilkp:masterfrom ebemunk:helper-fix
ebemunk wants to merge 1 commit intokamilkp:masterfrom
ebemunk:helper-fix
Conversation
otherwise it causes the element to disappear on click, without the helper appearing.
Contributor
Author
|
this was fixed by #47 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the sv-visibility-hidden is added on click. For elements that have helpers, this causes them to be hidden on click (but not move), yet the helper doesn't appear until a mousemove event.
this patch makes sure that the sv-visibility-hidden class gets applied at the same time when the helper element is created, and not before (on click)