Skip to content

fix(client): prevent crash on non-dict JSON-RPC error responses #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fguillot merged 1 commit into from
Mar 25, 2026
Merged

fix(client): prevent crash on non-dict JSON-RPC error responses #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kanboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,9 @@ def _parse_response(response: bytes) -> Any:
try:
body = json.loads(response.decode(errors="ignore"))

if "error" in body:
message = body.get("error").get("message")
error = body.get("error")
if error:
message = error.get("message") if isinstance(error, dict) else str(error)
raise ClientError(message)

return body.get("result")
Expand Down
7 changes: 7 additions & 0 deletions tests/test_kanboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ def test_application_error(self):
with self.assertRaises(kanboard.ClientError, msg="Internal error"):
self.client.remote_procedure()

def test_application_error_non_dict(self):
body = b'{"jsonrpc": "2.0", "error": "Something went wrong", "id": 123}'
self.urlopen.return_value.read.return_value = body

with self.assertRaises(kanboard.ClientError, msg="Something went wrong"):
self.client.remote_procedure()

def test_async_method_call_recognised(self):
method_name = "some_method_async"
result = self.client.is_async_method_name(method_name)
Expand Down