add ability to reference OIDC client secret from secret object

[olamilekan000]

Summary

change adds referencing of OIDC client secret using secret object.

What Type of PR Is This?

/kind feature
/kind api-change

Related Issue(s)

Fixes 130

Release Notes

Added referencing of OIDC secret using k8s secret object.

[mjudeikis]

This is just api? no implementation yet?

[mjudeikis]

Is there point having namespace here? Can we refer and use secrets cross-namespaces?

[xrstf]

Unless there's a strong reason to read cross-namespace resources, I would also vote against opening this can of worms.

[ntnn]

@olamilekan000 Can you drop the namespace please?

[ntnn]

Although, now that I think about it - it'd just but a blocker in if someone does need to read cross-namespace resources.

[ntnn]

Then again, I think it'd be best to reuse the LocalDataKeyRef:

kcp-operator/sdk/apis/operator/v1alpha1/common.go

Lines 73 to 81 in 7b7489f

	// LocalDataKeyReference is a reference to a namespace-local object storing
	// key-value data, i.e. ConfigMap or Secret.
	type LocalDataKeyReference struct {
	// Name of the object.
	Name string `json:"name"`
	// Key in the data.
	Key string `json:"key"`
	}

[olamilekan000]

okay, will look into this

[olamilekan000]

Just to bring to your attention, the secret field doesn't really have a flag in kcp, it was just there and not being used. I remember having a conversation about it on Slack with @mjudeikis.
These are the options I can see

cc @ntnn @xrstf

[xrstf]

@mjudeikis Since you introduced it and also left the field unused in #68: What was your plan for the ClientSecret?

[xrstf]

Any updates on this PR?

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olamilekan000]

/retest

[xrstf]

And what about the actual implementation?

[olamilekan000]

And what about the actual implementation?

I dropped a message here about it

[olamilekan000]

/retest

[mjudeikis]

lets close this and just deprecate this secrets field. we dont use it as kube oidc is secretless