Skip to content

fix: restore Kitty notification focus and same-terminal suppression#3

Open
nicobao wants to merge 11 commits intokdcokenny:mainfrom
nicobao:notify-kitty-tab-restore
Open

fix: restore Kitty notification focus and same-terminal suppression#3
nicobao wants to merge 11 commits intokdcokenny:mainfrom
nicobao:notify-kitty-tab-restore

Conversation

@nicobao
Copy link
Copy Markdown

@nicobao nicobao commented Apr 7, 2026

Summary

  • restore Kitty-aware notification suppression and click-to-focus behavior by tracking the originating Kitty window when remote control is available, and falling back to app-level suppression when Kitty cannot report the exact focused window so the active terminal stops receiving desktop banners
  • improve notification context by resolving the session title for ready, question, and permission events, while keeping question and permission prompts clearly prefixed with OC | outside the terminal
  • suppress notifications entirely in acp mode for Tidewave and other ACP hosts, and fix the stale upstream registry.json file mappings so they point at the real multi-file plugin sources without changing the upstream registry identity fields

Files In This PR

  • .gitignore
  • README.md
  • registry.json
  • src/notify.ts

Commit Breakdown

  • 1a4c947 introduced Kitty window/socket tracking, Kitty-specific focus detection and restore, session-title lookups for notification copy, README setup docs for Kitty remote control, and the initial registry wiring for this plugin
  • 62462bc removed facade publishing artifacts from the PR so review stayed focused on source and registry changes rather than generated output
  • 2e0ea09 hardened the click-focus path by only using Kitty's callback-driven restore path when remote control is actually available, while preserving the generic macOS app activation fallback
  • 59a7519 disabled notifications in acp mode and extended the macOS click callback window to reduce no-op clicks in Tidewave and other ACP-hosted sessions
  • 0bc54f9 restored app-level focus suppression when Kitty cannot report an exact focused window, which stops same-terminal ready/error/permission banners from firing just because Kitty remote control is unavailable
  • 15f41e2 stopped ignoring the transient files/ tree so local regeneration shows up explicitly instead of being silently hidden
  • e7f8431 restored the upstream registry schema/name/description while keeping the registry file mappings aligned with the real plugin sources
  • 194b38e, 00423eb, aadb5ae, and 561c41b added and then removed the fork-only registry helper tree so the final upstream PR stayed minimal

Validation

  • reviewed registry.json against upstream/main to preserve upstream identity fields while fixing the stale source/target paths
  • confirmed the final PR diff is limited to .gitignore, README.md, registry.json, and src/notify.ts

@nicobao nicobao changed the title fix: restore the originating Kitty tab from notification clicks fix: suppress ACP-hosted notifications and harden click focus Apr 9, 2026
@nicobao nicobao changed the title fix: suppress ACP-hosted notifications and harden click focus fix: restore Kitty notification focus and suppress ACP-hosted notifications Apr 9, 2026
@nicobao nicobao changed the title fix: restore Kitty notification focus and suppress ACP-hosted notifications fix: restore Kitty notification focus and same-terminal suppression Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant