Added Drop Down Menu by Ron Manguerra#5
Open
ronforrestron24 wants to merge 2 commits intokelixirr:mainfrom
Open
Added Drop Down Menu by Ron Manguerra#5ronforrestron24 wants to merge 2 commits intokelixirr:mainfrom
ronforrestron24 wants to merge 2 commits intokelixirr:mainfrom
Conversation
kelixirr
requested changes
Jan 2, 2025
Owner
There was a problem hiding this comment.
Hello, thank you for getting interested in the project. I just wanted to tell you a few mistakes. First of all your code is not aligned well with the updated version of the repository. This means you did not update your fork with the latest changes in the main.
There are other things too: You are not using pre-defined root variables in the index.css for styling part. Please use root variables defined in the index.css for styling.
First update your repo with the latest changes and then do it again:
Check out this issue for more details on how to do so: #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: This pull request is just a simple drop down menu for selecting options