Skip to content

add -o json to browsers playwright execute #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgarcia merged 1 commit into from
May 6, 2026
+12 −1
Merged

add -o json to browsers playwright execute #158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion cmd/browsers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1326,9 +1326,14 @@ type BrowsersPlaywrightExecuteInput struct {
Identifier string
Code string
Timeout int64
Output string
}

func (b BrowsersCmd) PlaywrightExecute(ctx context.Context, in BrowsersPlaywrightExecuteInput) error {
if in.Output != "" && in.Output != "json" {
return fmt.Errorf("unsupported --output value: use 'json'")
}

if b.playwright == nil {
pterm.Error.Println("playwright service not available")
return nil
Expand All @@ -1346,6 +1351,10 @@ func (b BrowsersCmd) PlaywrightExecute(ctx context.Context, in BrowsersPlaywrigh
return util.CleanedUpSdkError{Err: err}
}

if in.Output == "json" {
return util.PrintPrettyJSON(res)
}

rows := pterm.TableData{{"Property", "Value"}, {"Success", fmt.Sprintf("%t", res.Success)}}
PrintTableNoPad(rows, true)

Expand Down Expand Up @@ -2498,6 +2507,7 @@ func init() {
playwrightRoot := &cobra.Command{Use: "playwright", Short: "Playwright operations"}
playwrightExecute := &cobra.Command{Use: "execute <id> [code]", Short: "Execute Playwright/TypeScript code against the browser", Args: cobra.MinimumNArgs(1), RunE: runBrowsersPlaywrightExecute}
playwrightExecute.Flags().Int64("timeout", 0, "Maximum execution time in seconds (default per server)")
playwrightExecute.Flags().StringP("output", "o", "", "Output format: json for raw API response")
playwrightRoot.AddCommand(playwrightExecute)
browsersCmd.AddCommand(playwrightRoot)

Expand Down Expand Up @@ -2954,8 +2964,9 @@ func runBrowsersPlaywrightExecute(cmd *cobra.Command, args []string) error {
code = string(data)
}
timeout, _ := cmd.Flags().GetInt64("timeout")
output, _ := cmd.Flags().GetString("output")
b := BrowsersCmd{browsers: &svc, playwright: &svc.Playwright}
return b.PlaywrightExecute(cmd.Context(), BrowsersPlaywrightExecuteInput{Identifier: args[0], Code: strings.TrimSpace(code), Timeout: timeout})
return b.PlaywrightExecute(cmd.Context(), BrowsersPlaywrightExecuteInput{Identifier: args[0], Code: strings.TrimSpace(code), Timeout: timeout, Output: output})
}

func runBrowsersFSNewDirectory(cmd *cobra.Command, args []string) error {
Expand Down
Loading