fix: send query params for NewFromArchive#27
Merged
hiroTamada merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Pass VolumeNewFromArchiveParams to request execution so required query fields like name and size_gb are serialized for /volumes/from-archive requests. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VolumeService.NewFromArchiveto passVolumeNewFromArchiveParamsintoExecuteNewRequest.name,size_gb) are serialized forPOST /volumes/from-archive.Test plan
cd /Users/hirotamada/kernel/kernel/hypeman-go && go test ./...Made with Cursor
Note
Low Risk
Small client-side fix to include missing query parameters; minimal blast radius beyond the
NewFromArchivecall path.Overview
VolumeService.NewFromArchivenow passesVolumeNewFromArchiveParamstorequestconfig.ExecuteNewRequestinstead ofnil, ensuring required query parameters (e.g.,name,size_gb) are serialized forPOST /volumes/from-archivewhile still streaming the tarball as the request body.Written by Cursor Bugbot for commit a8c45a6. This will update automatically on new commits. Configure here.