.github: workflow dispatch fixes #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Alpe <richard@bit42.se>
Reduce number of lines. Required = false is the default. Signed-off-by: Richard Alpe <richard@bit42.se>
rical
force-pushed
the
trigger-github-workflow
branch
from
c445745 to
96dd69e
Compare
rical
changed the title
rical
force-pushed
the
trigger-github-workflow
branch
4 times, most recently
from
bf380ba to
b865593
Compare
Signed-off-by: Richard Alpe <richard@bit42.se>
rical
force-pushed
the
trigger-github-workflow
branch
from
b865593 to
fc0a68a
Compare
rical
changed the title
troglobit
approved these changes
Jul 29, 2025
Contributor
troglobit
left a comment
troglobit
left a comment
There was a problem hiding this comment.
Nice and clean, awesome!
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the GitHub workflow to handle both workflow_dispatch and workflow_call events properly by adding environment variables and moving input definitions to support both trigger types.
- Adds missing input parameters (target, name) to workflow_dispatch section
- Creates environment variables to handle inputs from both workflow_dispatch and workflow_call events
- Updates all job references to use environment variables instead of direct input references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Tick relevant boxes, this PR is-a or has-a: