-
Notifications
You must be signed in to change notification settings - Fork 14
cli: use operational data in show container [name]
#1339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d9c94ec to
5fd0dac
Compare
|
@mattiaswal note, new Canvas class added and firewall commands in Update: of course I forgot to check the unit tests! 🤦♂️ |
https://github.com/finit-project/finit/releases/tag/4.15 Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Finit is capable of setting up all basic file systems, even /run but Infix relies on it allowing executing scripts (dagger and container) so leave that for now. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This patch adds support for flexible columns. When a column is marked as flexible it means it can be stretched when printing the table to an optional minimal table width. Multiple columns can be marked and when this occurs the padding is applied equally to all columns. Also, make sure to only add 2 char padding between columns, not always at the end, or we will require larger terminal than necessary. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The constaint was supposed to be 50% of one CPU core, or 500 millicores as per Kubernetes nomenclature. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Leverage the operational data to present a more human-friendly view of containers in the CLI. Replacing the podman script wrapper. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The original 'show firewall log' just did the same as the 'show log firewall' command. This new implementation allows showing pretty-printed firewall log which is admittedly easier on the eyes. Also, add 'show firewall matrix' to just show the zone matrix overview. Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
5fd0dac to
1030bae
Compare
mattiaswal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
Thanks! Awesome to get this one out of the way, it's been bugging me all Christmas and New Years! 😆 |
Description
This is a follow-up to the
container-limitsbranch posted earlier, PR #1327. It holds:/etc/fstab, Finit can handle most of standard mountsCanvasclass incli-prettySimpleTableand newCanvasclassesChecklist
Tick relevant boxes, this PR is-a or has-a: