Skip to content

Conversation

@troglobit
Copy link
Contributor

@troglobit troglobit commented Jan 1, 2026

Description

This is a follow-up to the container-limits branch posted earlier, PR #1327. It holds:

  • Bump of Finit to v4.15
  • Simplify /etc/fstab, Finit can handle most of standard mounts
  • Introduce new Canvas class in cli-pretty
  • Refactor 'show firewall [cmd]' commands to use SimpleTable and new Canvas classes
  • Add pretty-printing of entire firewall log 'show firewall log', raw format: 'show log firewall'
  • Updated documentation for container resource limits

Checklist

Tick relevant boxes, this PR is-a or has-a:

  • Bugfix
    • Regression tests
    • ChangeLog updates (for next release)
  • Feature
    • YANG model change => revision updated?
    • Regression tests added?
    • ChangeLog updates (for next release)
    • Documentation added?
  • Test changes
    • Checked in changed Readme.adoc (make test-spec)
    • Added new test to group Readme.adoc and yaml file
  • Code style update (formatting, renaming)
  • Refactoring (please detail in commit messages)
  • Build related changes
  • Documentation content changes
    • ChangeLog updated (for major changes)
  • Other (please describe):

@troglobit troglobit requested a review from mattiaswal January 1, 2026 17:25
@troglobit troglobit force-pushed the container-operational branch from d9c94ec to 5fd0dac Compare January 2, 2026 18:36
@troglobit troglobit requested a review from mattiaswal January 2, 2026 18:38
@troglobit
Copy link
Contributor Author

troglobit commented Jan 2, 2026

@mattiaswal note, new Canvas class added and firewall commands in cli_pretty have also been converted to SmartTable (and Canvas).

Update: of course I forgot to check the unit tests! 🤦‍♂️

Finit is capable of setting up all basic file systems, even /run but
Infix relies on it allowing executing scripts (dagger and container)
so leave that for now.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
This patch adds support for flexible columns.  When a column is marked
as flexible it means it can be stretched when printing the table to an
optional minimal table width.  Multiple columns can be marked and when
this occurs the padding is applied equally to all columns.

Also, make sure to only add 2 char padding between columns, not always
at the end, or we will require larger terminal than necessary.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The constaint was supposed to be 50% of one CPU core, or 500 millicores
as per Kubernetes nomenclature.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Leverage the operational data to present a more human-friendly view of
containers in the CLI.  Replacing the podman script wrapper.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
The original 'show firewall log' just did the same as the 'show log firewall'
command.  This new implementation allows showing pretty-printed firewall log
which is admittedly easier on the eyes.

Also, add 'show firewall matrix' to just show the zone matrix overview.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit force-pushed the container-operational branch from 5fd0dac to 1030bae Compare January 2, 2026 19:09
Copy link
Contributor

@mattiaswal mattiaswal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 👍

@troglobit troglobit merged commit 7114b01 into main Jan 2, 2026
7 checks passed
@troglobit troglobit deleted the container-operational branch January 2, 2026 20:08
@troglobit
Copy link
Contributor Author

Great work 👍

Thanks! Awesome to get this one out of the way, it's been bugging me all Christmas and New Years! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants