Skip to content

Bump @platformatic/kafka version#484

Merged
kjamrog merged 2 commits into
mainfrom
update_kafka_version
Jun 18, 2026
Merged

Bump @platformatic/kafka version#484
kjamrog merged 2 commits into
mainfrom
update_kafka_version

Conversation

@kjamrog

@kjamrog kjamrog commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps @platformatic/kafka to ^2.3.1 (and Node engine to >= 22.22.0).

Topics deletion fix

@platformatic/kafka 2.3.x has a regression in Admin#deleteTopics: on the error path it bypasses the deduplication callback, leaving a stale entry in the per-instance dedup cache. Reusing the same Admin afterwards causes subsequent deleteTopics calls for the same topics to hang forever.

This broke the init - close tests, which share a singleton kafkaAdmin and delete the same topics in beforeEach: the first delete (topics don't exist yet) errors and pollutes the cache, so every later delete times out. Tests passed individually but failed when run together.

Workaround: a shared deleteExistingTopics test helper lists topics first and only deletes the ones that exist, avoiding the broken error path. The upstream fix is being pushed separately.

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 13697478-0ae0-4a03-8ac7-0dd760b84ad0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch update_kafka_version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@kjamrog kjamrog added the minor label Jun 18, 2026
"version": "0.11.4",
"engines": {
"node": ">= 22.14.0"
"node": ">= 22.22.0"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be compatible with @platformatic/kafka requirement

/**
* Deletes only the topics that currently exist.
*
* Workaround for a regression in @platformatic/kafka >= 2.3.0 where Admin#deleteTopics

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a simple fix for @platformatic/kafka, I will create PR for it. Since we only use topics deletion in tests and the workaround is clean (checking existing topics before deletion makes sense), it should be fine to proceed with the version upgrade

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR for the library: platformatic/kafka#323

@kjamrog kjamrog marked this pull request as ready for review June 18, 2026 10:22
@kjamrog kjamrog merged commit 9c01476 into main Jun 18, 2026
17 of 19 checks passed
@kjamrog kjamrog deleted the update_kafka_version branch June 18, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants