Bump @platformatic/kafka version#484
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "version": "0.11.4", | ||
| "engines": { | ||
| "node": ">= 22.14.0" | ||
| "node": ">= 22.22.0" |
There was a problem hiding this comment.
To be compatible with @platformatic/kafka requirement
| /** | ||
| * Deletes only the topics that currently exist. | ||
| * | ||
| * Workaround for a regression in @platformatic/kafka >= 2.3.0 where Admin#deleteTopics |
There was a problem hiding this comment.
It should be a simple fix for @platformatic/kafka, I will create PR for it. Since we only use topics deletion in tests and the workaround is clean (checking existing topics before deletion makes sense), it should be fine to proceed with the version upgrade
There was a problem hiding this comment.
PR for the library: platformatic/kafka#323
Summary
Bumps
@platformatic/kafkato^2.3.1(and Node engine to>= 22.22.0).Topics deletion fix
@platformatic/kafka2.3.x has a regression inAdmin#deleteTopics: on the error path it bypasses the deduplication callback, leaving a stale entry in the per-instance dedup cache. Reusing the sameAdminafterwards causes subsequentdeleteTopicscalls for the same topics to hang forever.This broke the
init - closetests, which share a singletonkafkaAdminand delete the same topics inbeforeEach: the first delete (topics don't exist yet) errors and pollutes the cache, so every later delete times out. Tests passed individually but failed when run together.Workaround: a shared
deleteExistingTopicstest helper lists topics first and only deletes the ones that exist, avoiding the broken error path. The upstream fix is being pushed separately.