docs: add FUNC_USERNAME/PASSWORD env vars documentation#6543
docs: add FUNC_USERNAME/PASSWORD env vars documentation#6543Kunal1522 wants to merge 1 commit intoknative:mainfrom
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
|
Welcome @Kunal1522! It looks like this is your first PR to knative/docs 🎉 |
|
/cc @gauron99 @lkingland |
|
Thanks for the ping. I commented on the mentioned issue here |
|
@gauron99 is this docs change still relevant? |
bff0eea to
e091285
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Kunal1522 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
i think the verify mkdocs strict check is unrelated |
|
@gauron99 it's unrelated - you can lgtm and approve when you're ready and it won't block the PR |
|
The PR is still a draft |
|
my bad i missed to mark it for review |
|
@Kunal1522 could we mention this for |
Fixes knative/func#3299
Proposed Changes
FUNC_USERNAMEandFUNC_PASSWORDenvironment variables in docs/snippets/proc-building-function.md.FUNC_USERNAMEandFUNC_PASSWORDenvironment variables in docs/snippets/proc-deploying-function.md.host,s2i, andpack) for private registry authentication, following the refactoring in knative/func#3298.