Remove hardcoded registry and image from ML func.yaml files#6610
Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom Mar 31, 2026
Merged
Conversation
Fixes knative#6471 Remove the hardcoded 'registry: localhost:5000' and image SHA256 digests from the ML service func.yaml files in the bookstore tutorial. This allows users to configure their own container registry via the FUNC_REGISTRY environment variable or --registry flag, as documented in the tutorial instructions. The hardcoded values prevented dynamic registry configuration and caused deployment failures when users tried to follow the tutorial with their own registries. Changes: - Remove registry: localhost:5000 from both func.yaml files - Remove deploy.image with hardcoded SHA256 digests - Allow func CLI to handle registry configuration dynamically
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
knative-prow
bot
added
the
size/XS
|
Welcome @vamsi-01! It looks like this is your first PR to knative/docs 🎉 |
Member
|
/assign @Leo6Leo @lkingland |
Member
|
The changes looks good to me |
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Leo6Leo, vamsi-01 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6471
Proposed Changes
Remove hardcoded registry and image values from ML service
func.yamlfiles to enable dynamic registry configuration.registry: localhost:5000from ML-bad-word-filter/func.yamlregistry: localhost:5000from ML-sentiment-analysis/func.yamldeploy.imagefields with SHA256 digests from both filesProblem
The bookstore tutorial ML services had hardcoded
registry: localhost:5000and image SHA256 digests in theirfunc.yamlfiles. This prevented users from using their own container registries via theFUNC_REGISTRYenvironment variable or--registryflag, contradicting the tutorial documentation and causing deployment failures.Solution
By removing these hardcoded values, the
funcCLI can now dynamically determine the registry from:FUNC_REGISTRYenvironment variable--registrycommand flagTesting
Users can now successfully deploy with their own registry: