Update default minimum TLS version to 1.3#8916
Open
Fedosin wants to merge 1 commit intoknative:mainfrom
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Fedosin The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
knative-prow
bot
added
the
size/M
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8916 +/- ##
==========================================
- Coverage 51.02% 51.02% -0.01%
==========================================
Files 409 409
Lines 22001 21999 -2
==========================================
- Hits 11226 11224 -2
Misses 9911 9911
Partials 864 864 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This updates the eventingtls package to use TLS 1.3 as the default minimum version, aligning with the default behavior of `knative.dev/pkg/network/tls`. The fallback to TLS 1.2 and the associated TODO have been removed. Additionally, tests asserting the default MinVersion have been removed from `pkg/eventingtls` and `cmd/requestreply`, as this configuration is now handled entirely by the underlying `knative.dev/pkg/network/tls` utility. Signed-off-by: Mikhail Fedosin <mfedosin@redhat.com>
Contributor
Author
|
/retest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed Changes
This updates the eventingtls package to use TLS 1.3 as the default minimum version, aligning with the default behavior of
knative.dev/pkg/network/tls. The fallback to TLS 1.2 and the associated TODO have been removed.Additionally, tests asserting the default MinVersion have been removed from
pkg/eventingtlsandcmd/requestreply, as this configuration is now handled entirely by the underlyingknative.dev/pkg/network/tlsutility.🧹
Pre-review Checklist
Release Note
Docs